Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MxDSBuffer::ParseChunk to 100% #1257

Merged
merged 2 commits into from
Dec 22, 2024
Merged

MxDSBuffer::ParseChunk to 100% #1257

merged 2 commits into from
Dec 22, 2024

Conversation

disinvite
Copy link
Collaborator

Not a full beta match because the beta does not call MxDSStreamingAction::FUN_100cd2d0. It does almost the same thing but like this:

if (m_unk0x30->GetDuration() != -1) {
    m_unk0x30->SetLoopCount(m_unk0x30->GetLoopCount() - 1);
    m_unk0x30->SetUnknowna8toDuration()
}

Filled in some other beta addrs and fixed member set order in MxDSBuffer and MxDSChunk constructors.

foxtacles
foxtacles reviewed Dec 22, 2024
View reviewed changes
LEGO1/omni/src/stream/mxdsbuffer.cpp Outdated
}

if (buffer) {
if (!buffer || buffer->AllocateBuffer(length, e_allocate) || buffer->CalcBytesRemaining((MxU8*) p_data) ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should test for != SUCCESS on both function calls here so it's clearer

@foxtacles foxtacles merged commit 276ad8d into isledecomp:master Dec 22, 2024
12 checks passed
@disinvite disinvite deleted the pr-dsbuf3 branch December 22, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foxtacles foxtacles foxtacles left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@disinvite @foxtacles